Fix vite6 environment detection#173
Conversation
🦋 Changeset detectedLatest commit: 2a72396 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Running with vitest, this fixes a ton of issues.
Before, I got hundreds of this generic:
Error: Client-only API called on the server side. Run client-only code in onMount, or conditionally run client-only component with .
After, I get actual useful messages:
Warning: useRouter must be used inside a component!
|
@brenelz , can you add a patch changeset to this? |
|
There is confirmation that this fixes also: Confirmed by this stackblitz https://stackblitz.com/edit/vitejs-vite-1k7n1gjp?file=src%2FApp.jsx |
|
We think the new CR flow break because the workflow was added after this PR was opened. EDIT: it was github app permissions - works now. |
3 participants
I believe this fixes the "Client-only API called on the server side. Run client-only code in onMount, or conditionally run" error when using vite6.
I'm not 100% on the implementation but tried to replicate the conditions that were removed in this pr. I am not sure if there is an order to where it picks up. I think
developmentandbrowserweren't being added correctly and they were before.https://github.com/solidjs/vite-plugin-solid/pull/163/files
Closes #171